faster lookup of holdings #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteverman
approved these changes
Jul 12, 2021
| [cluster.holdings.to_a.find {|h| h == holding && h.date_received != holding.date_received }] | ||
| # Build a fast lookup for holdings | ||
| # {update_key1: h1, update_key2: h2, ...} | ||
| @cluster_holdings_lookup ||= cluster.holdings.group_by(&:update_key) |
There was a problem hiding this comment.
Is there a reason to not use @cluster_holdings_lookup for the large clusters as well?
There was a problem hiding this comment.
Not really, other than that we wanted to have it tested & working for the non-large-cluster branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to ClusterHolding, specifically to the methods check_for_duplicate_uuids! and find_old_holdings, in order to improve speed when adding holdings.