DEV-1472 post-zephir processing: get database config from env vars #63
+81
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move all Perl DB connection code to a single module under `perl_lib` - Remove config/database.yml - Add necessary `MARIADB_HT...` and `MARIADB_RIGHTS...` vars to docker compose.
aelkiss
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
This all looks right to me. Note that we will need to get https://hathitrust.atlassian.net/browse/DEV-1471 done and merged before deploying this.
|
|
||
| my $sdr_dbh; | ||
| $sdr_dbh = DBI->connect( "DBI:MariaDB:$db_name:$db_server", $db_user, $db_passwd, | ||
| { RaiseError => 0, AutoCommit => 1 } ) || die "Cannot connect: $DBI::errstr"; |
There was a problem hiding this comment.
Just noting that the move removes the AutoCommit => 1, but that should be fine as this code is only using the read-only connection (and we weren't previously using autocommit for the read-write stuff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perl_libMARIADB_HT...andMARIADB_RIGHTS...vars to docker compose.