Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a consistent way of referring to the MaskRCNN implementation #17

Closed
havanagrawal opened this issue Dec 25, 2018 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@havanagrawal
Copy link
Owner

Since the matterport implementation is not available via a package manager, we want a way to consistently refer to the library from code.

  • One solution is to simply clone the repository as a subdirectory in this one, the license allows us to do this. The pro is that this is the simplest solution, the con is that it will bloat our own repo. We could strip out the parts that we don't need to alleviate that issue.
  • Another solution is to ensure that everyone has an environment variable that points to their local directory for MaskRCNN. For example:
    MASK_CNN_DIR='/Users/havan/Dropbox/CP/Git/MaskRCNN'
    We would then add all necessary paths from code, preferably from a central module/lib:
mask_rcnn_path = os.environ.get('MASK_CNN_DIR')
sys.path.append(os.path.join(mask_rcnn_path, 'mrcnn'))
sys.path.append(os.path.join(mask_rcnn_path, 'samples', 'coco'))

import utils
import coco
...

A subsequent task would be to move all model related code to a central library that we can simply import from. Computing mAP (mean average precision) is one such piece of code, that is currently duplicated across notebooks.

Please let me know what your thoughts are on this. Mentioning @pshivraj since we discussed this offline.

@havanagrawal havanagrawal self-assigned this Dec 25, 2018
@lmtoan
Copy link
Collaborator

lmtoan commented Dec 30, 2018

Thanks Havan, @pshivraj

My thought is that we should clone the mrcnn module and incorporate it into our clomask repo. That way, we can easily customize any training/inference class if needed. The mrcnn module only has 5 scripts so it shouldn't bloat our repo that much. We can put all our research code in a research folder, similar to one of their samples/xxx folder.

When I interned at Clobotics, they copied the giant Caffe repo and developed their own stuff in parallel folders. At the end of the Capstone, I think they would prefer us passing on a custom mrcnn module with detailed requirements/installation instructions, without referencing back and forth to matterport repo.

Let's discuss more.

@havanagrawal havanagrawal added the enhancement New feature or request label Mar 7, 2019
@havanagrawal
Copy link
Owner Author

Fixed by #32, #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants