Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training pipeline #26

Closed
wants to merge 11 commits into from
Closed

Training pipeline #26

wants to merge 11 commits into from

Conversation

pshivraj
Copy link
Collaborator

@pshivraj pshivraj commented Feb 15, 2019

This PR is an end to end pipeline for model Training. It includes:

  • Data pre-processing using pre_process.py to generate .h5 file for masks.

  • Custom Config for clomask Dataset. (config.py)

  • Model Training using coco and imagenet weights. (train.py)

This caters to following issues: #18 #17 #26

@tejasmhos
Copy link
Collaborator

I think the training pipeline is fine. It can be merged to the master branch.

tejasmhos
tejasmhos previously approved these changes Feb 16, 2019

def model_train(self):

augmentation = iaa.Sequential([
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this line number and file in mind whenever Yipeng asks if we perform any image augmentation during training.

@lmtoan
Copy link
Collaborator

lmtoan commented Feb 17, 2019

Thanks Puru. Since we need to train images with no bottle/box/bag, should we stash more commit on this branch or merge this and create another feature branch?

Just cosmetics:

  • Now that we move the mrcnn/ module to our repository, let's add __init__.py, setup.py, and other requirements.txt to establish it as a proper module?
  • I think all scripts in scripts/* should surface to mrcnn/ and move the mask_data/ out of the current folder. I like mask_data to be in our repo for testing and documentation.

"""
Initialize the class with dataset info.
"""
with open(ROOT_DIR + 'id_map.json') as mapping_file:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check in the id_map.json file? Or I can add that long list of class labels in config.py (with "book" becomes "bags").

Copy link
Collaborator Author

@pshivraj pshivraj Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmtoan I have added the id_map.json to the pull request. Can you approve my latest commit so that I can merge.

havanagrawal
havanagrawal previously approved these changes Feb 18, 2019
@pshivraj pshivraj dismissed stale reviews from havanagrawal and tejasmhos via 619a958 February 19, 2019 07:19
@pshivraj
Copy link
Collaborator Author

I am closing this pull request for now.

@pshivraj pshivraj closed this Feb 25, 2019
@pshivraj pshivraj mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants