Validation setup #13
Merged
Validation setup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshivraj
requested review from
vivanvish,
havanagrawal,
lmtoan and
tejasmhos
|
The title for each plot is below the plot and can be misleading for some of the middle plots. Can we fix this quickly, or should we just go ahead and merge? |
There is one more fix around one of the images validation mAP not coming correctly which i need to fix, i'll update the PR with title and mAP fix. For now lets hold the merge. |
|
Merge for now. We'll look into it later. |
|
@havanagrawal check the current commit, I have fixed the title issue and added additional image. |
lmtoan
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #7 and adds Validation setup notebook to benchmark current implementation of matterport measured against mAP for predefined set of validation images .