Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook fix #34

Merged
merged 5 commits into from
Mar 9, 2019
Merged

Notebook fix #34

merged 5 commits into from
Mar 9, 2019

Conversation

pshivraj
Copy link
Collaborator

@pshivraj pshivraj commented Mar 8, 2019

This small PR fixes output folder creating in the Synthetic-Data-Creation-for-Retail-Environments.ipynb notebook.

output_dir = "data/"
if not os.path.exists(output_dir ):
    os.mkdir(output_dir )

@havanagrawal
Copy link
Owner

havanagrawal commented Mar 8, 2019

Instead of handling this in the notebook, just replace this line here with

os.makedirs(save_path)

@pshivraj
Copy link
Collaborator Author

pshivraj commented Mar 8, 2019

Instead of handling this in the notebook, just replace this line here with

os.makedirs(save_path)

Thanks this makes much more sense.

This has been fixed in the latest commit.

Copy link
Owner

@havanagrawal havanagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@havanagrawal havanagrawal merged commit 00ecec8 into master Mar 9, 2019
@havanagrawal havanagrawal deleted the notebook_fix branch March 22, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants