inoculate test fixes #511
Merged
inoculate test fixes #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `--nocapture` flag to `cargo inoculate test` incorrectly disables the processing of test output, so we can't actually detect that tests are running. This is wrong. This commit makes it just print each line of output to stdout, but still try to parse them.
hawkw
added a commit
that referenced
this pull request
Jan 11, 2025
Currently, the inoculate test command sets a timeout of 60 seconds, and abruptly kills QEMU if it takes longer than that. This is no longer nearly long enough to run our tests. This commit increases the timeout to 1200 seconds (20 minutes). This is a long time, but our tests take a while to run, and recall that this timeout applies to booting the kernel *and running all the tests*, rather than being enforced on a per-test basis. We should probably make the timeout much smarter than just "kill the QEMU process after 20 minutes", and instead do it only if we don't see any interesting test output, or something. But, this is better than just always failing test runs because we're stupid about timeouts, I guess.
hawkw
force-pushed
the
eliza/fix-inoculate-nocapture
branch
from
4330bc1 to
3380090
Compare
Currently, the inoculate test command sets a timeout of 60 seconds, and abruptly kills QEMU if it takes longer than that. This is no longer nearly long enough to run our tests. This commit increases the timeout to 1200 seconds (20 minutes). This is a long time, but our tests take a while to run, and recall that this timeout applies to booting the kernel *and running all the tests*, rather than being enforced on a per-test basis. We should probably make the timeout much smarter than just "kill the QEMU process after 20 minutes", and instead do it only if we don't see any interesting test output, or something. But, this is better than just always failing test runs because we're stupid about timeouts, I guess.
hawkw
force-pushed
the
eliza/fix-inoculate-nocapture
branch
from
3380090 to
a1249f4
Compare
hawkw
added a commit
that referenced
this pull request
Jan 11, 2025
Currently, the `--nocapture` flag to `cargo inoculate test` incorrectly disables the processing of test output, so we can't actually detect that tests are running. This is wrong. This commit makes it just print each line of output to stdout, but still try to parse them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the inoculate test command sets a timeout of 60 seconds, and
abruptly kills QEMU if it takes longer than that. This is no longer
nearly long enough to run our tests. This commit increases the timeout
to 1200 seconds (20 minutes). This is a long time, but our tests take a
while to run, and recall that this timeout applies to booting the kernel
and running all the tests, rather than being enforced on a per-test
basis.
We should probably make the timeout much smarter than just "kill the
QEMU process after 20 minutes", and instead do it only if we don't see
any interesting test output, or something. But, this is better than just
always failing test runs because we're stupid about timeouts, I guess.
I also fixed a bug where
--nocapturedisables the test protocol output parsing, breaking our detection of test failure/successes. Whoopsie.