Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css support for scaleMode, imageVerticalAlign, imageHorizontalAlign. #91

Closed
wants to merge 8 commits into from

Conversation

aW4KeNiNG
Copy link
Member

@aW4KeNiNG aW4KeNiNG commented Jan 22, 2017

For example:

.image {
    scale-mode: fit-inside;
    image-horizontal-align: center;
    image-vertical-align: bottom;
}

@aW4KeNiNG
Copy link
Member Author

aW4KeNiNG commented Jan 23, 2017

@ianharrigan, check if 4c198ea is the correct way.

I'm wonder if the user set the CSS style at start, it could be a problem to set the value via Haxe. For example the hidden property. If the css is hidden: true, and after that they change the hidden value to false via Haxe, then what happens if applyStyle is called? It would assign the css property again, right? I don't see style.hidden = newValue.

I don't know if I'm tired, the night or what, but I don't see if it is a real problem. Am I missing something? :)

@aW4KeNiNG
Copy link
Member Author

aW4KeNiNG commented Jan 25, 2017

I don't know what happened the last day. I would be very tired.

8f7b164 is the correct way I think.

PD: I think travis is wrong...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants