Various serialization fixes. (#932)

hazelcast · Feb 9, 2023 · 23a45ba · 23a45ba
1 parent f7c6247
commit 23a45ba
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/aggregate/aggregate_distinct.go b/aggregate/aggregate_distinct.go
@@ -46,13 +46,13 @@ func (a aggDistinct) ClassID() (classID int32) {
 func (a aggDistinct) WriteData(output serialization.DataOutput) {
 	writeAttrPath(output, a.attrPath)
 	// member side field, not used in client
-	output.WriteInt64(0)
+	output.WriteInt32(0)
 }
 
 func (a *aggDistinct) ReadData(input serialization.DataInput) {
 	a.attrPath = input.ReadString()
 	// member side field, not used in client
-	input.ReadInt64()
+	input.ReadInt32()
 }
 
 func (a aggDistinct) String() string {

diff --git a/internal/serialization/default_portable_writer.go b/internal/serialization/default_portable_writer.go
@@ -269,7 +269,7 @@ func (pw *DefaultPortableWriter) GetRawDataOutput() serialization.DataOutput {
 		pw.output.PWriteInt32(pw.offset+index*Int32SizeInBytes, pos)
 		pw.raw = true
 	}
-	return pw.output.ObjectDataOutput
+	return pw.output
 }
 
 func (pw *DefaultPortableWriter) End() {

diff --git a/internal/serialization/object_data.go b/internal/serialization/object_data.go
@@ -659,6 +659,10 @@ func NewPositionalObjectDataOutput(length int, service *Service, bigEndian bool)
 	return &PositionalObjectDataOutput{NewObjectDataOutput(length, service, bigEndian)}
 }
 
+func (p *PositionalObjectDataOutput) WriteObject(object interface{}) {
+	p.service.WriteObject(p, object)
+}
+
 func (p *PositionalObjectDataOutput) PWriteByte(pos int32, v byte) {
 	p.buffer[pos] = v
 }

diff --git a/internal/serialization/serialization.go b/internal/serialization/serialization.go
@@ -68,6 +68,9 @@ func (s *Service) ToData(object interface{}) (r Data, err error) {
 			err = makeError(rec)
 		}
 	}()
+	if object == nil {
+		return nil, nil
+	}
 	if serData, ok := object.(Data); ok {
 		return serData, nil
 	}