This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
terraform.limits #115
Merged
terraform.limits #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationD
suggested changes
Jan 21, 2021
terraform/main.mk
Outdated
| then echo "\n\033[32m[OK]\033[0m $(item) limit"; \ | ||
| else echo "\n\033[33m[WARNING]\033[0m $(item) limit \(Value:$(shell echo $(AWS_LIMITS_LIST) | $(JQ) -r '.$(item)[].value')\) exceeded! \ | ||
| Current value:$(shell grep -c "+ resource \"$(item)\"" $(ENV_DIR)/tfplan.txt) \ | ||
| \033[33m To request a service quota increase:\033[0m \033[36m aws service-quotas request-service-quota-increase --service-code $(shell echo $(AWS_LIMITS_LIST) | $(JQ) -r '.$(item)[].service') --quota-code $(shell echo $(AWS_LIMITS_LIST) | $(JQ) -r '.$(item)[].quotacode') --desired-value \<your_desired_value\> \033[0m"; fi ))) ) |
There was a problem hiding this comment.
Let's add another newline before the actual commands list
There was a problem hiding this comment.
@AutomationD you know yesterday I spent time to try to format output with new lines but due to the echo at the begining of AWS_LIMITS command it doesn't work, any ideas how to make output info with new lines?
There was a problem hiding this comment.
@AutomationD I tried - no result, also tried to replace echo with printf - didn't work as well :(
There was a problem hiding this comment.
@AutomationD Output fixed, please approve
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find ability to estimate if all there are any limits that we would need to raise to deploy infra
Testing:
