Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Add ability to add projects to sub-directories #124

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

igorkotof
Copy link
Contributor

Example:
api/squibby.deploy:
$(SLS...)
api/nutella.deploy:
$(SLS...)
ml/rodent-classifier.deploy:
$(SLS...)

Testing:
asciicast

@igorkotof igorkotof requested a review from AutomationD February 3, 2021 21:41
@igorkotof
Copy link
Contributor Author

@kobrikx
Copy link
Contributor

kobrikx commented Feb 4, 2021

LGTM

main.mk Outdated Show resolved Hide resolved
@igorkotof
Copy link
Contributor Author

@AutomationD comments fixed, anything else?

main.mk Outdated Show resolved Hide resolved
Copy link

@andrei-andryieuski andrei-andryieuski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the services with the same names in different subfolders?
And how can we process this occasion ?

@AutomationD
Copy link
Contributor

AutomationD commented Feb 5, 2021 via email

@igorkotof
Copy link
Contributor Author

Can we have the services with the same names in different subfolders?
And how can we process this occasion ?

@AutomationD @andrei-andryieuski I can't see any problems if you specify <sub-dir>/<service_name>.any_action as a target. Any objections?

main.mk Outdated Show resolved Hide resolved
@igorkotof igorkotof merged commit 73e55a3 into master Feb 10, 2021
@igorkotof igorkotof deleted the feature/projects-to-subdir branch February 10, 2021 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants