Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Remove latest tag from image #142

Merged
merged 7 commits into from
May 12, 2021
Merged

Remove latest tag from image #142

merged 7 commits into from
May 12, 2021

Conversation

kobrikx
Copy link
Contributor

@kobrikx kobrikx commented Apr 29, 2021 •
edited
Loading

What's new:

  • Add remove of $(TAG_LATEST)

How to use:

  • To remove TAG_LATEST you need to call in Makefile for example, CMD_ECR_DOCKER_PURGE_CACHE command
  app.purge-cache:
	$(CMD_ECR_DOCKER_PURGE_CACHE)

Testing done:

Remove TAG_LATEST when its exist:

asciicast

When TAG_LATEST doesn't exists:

asciicast

@kobrikx kobrikx requested a review from AutomationD April 30, 2021 08:54
@kobrikx
Copy link
Contributor Author

kobrikx commented Apr 30, 2021

ICMK: Add ability to clear container's cache

@AutomationD
Copy link
Contributor

AutomationD commented Apr 30, 2021 •
edited
Loading

BTW, @kobrikx please provide asciinema demo when done with the PR.

@kobrikx kobrikx changed the title WIP: Remove latest tag from image Remove latest tag from image May 4, 2021
@kobrikx kobrikx requested review from gloovers and igorkotof May 4, 2021 08:10
AutomationD
AutomationD approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with minor renaming

aws/ecs.mk Outdated Show resolved Hide resolved
@kobrikx kobrikx requested a review from AutomationD May 12, 2021 17:05
@kobrikx kobrikx merged commit 67b4405 into master May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AutomationD AutomationD AutomationD approved these changes

@gloovers gloovers Awaiting requested review from gloovers

@igorkotof igorkotof Awaiting requested review from igorkotof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobrikx @AutomationD