Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Feature/ssm install #76

Merged
merged 7 commits into from
Nov 6, 2020
Merged

Feature/ssm install #76

merged 7 commits into from
Nov 6, 2020

Conversation

igorkotof
Copy link
Contributor

  • Added ICMK installation of Session Manager Plugin on MacOS or any GNU/Linux
    • Download
    • Install
    • Cleanup
    • Verification

NOTE: Should be tested on MacOS by someone from the team

Testing:
asciicast

@igorkotof igorkotof requested a review from AutomationD November 5, 2020 21:07
@igorkotof
Copy link
Contributor Author

@igorkotof
Copy link
Contributor Author

@AutomationD any ideas how we can hide the outputs from download and installation? :)

@AutomationD
Copy link
Contributor

@AutomationD any ideas how we can hide the outputs from download and installation? :)

Let's start with curl -s and see if that is going to be enough.
As an option, you can add @ in front of a command to hide it from the make output

@igorkotof
Copy link
Contributor Author

As an option, you can add @ in front of a command to hide it from the make output

@AutomationD I tried @ - it's hide a command but not output

@AutomationD
Copy link
Contributor

MacOS Test:

 make ssm-plugin                                                             
awk: fatal: cannot open file `/etc/*-release' for reading: No such file or directory
/bin/sh: lscpu: command not found
awk: fatal: cannot open file `/etc/*-release' for reading: No such file or directory
awk: fatal: cannot open file `/etc/*-release' for reading: No such file or directory
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 4963k  100 4963k    0     0  2536k      0  0:00:01  0:00:01 --:--:-- 2535k
Archive:  sessionmanager-bundle.zip
   creating: sessionmanager-bundle/
 extracting: sessionmanager-bundle/VERSION
  inflating: sessionmanager-bundle/LICENSE
  inflating: sessionmanager-bundle/seelog.xml.template
  inflating: sessionmanager-bundle/install
   creating: sessionmanager-bundle/bin/
  inflating: sessionmanager-bundle/bin/session-manager-plugin
awk: fatal: cannot open file `/etc/*-release' for reading: No such file or directory
awk: fatal: cannot open file `/etc/*-release' for reading: No such file or directory

I think the issue is that $(shell ) is evaluated before actual task execution. My suggestion would be to shift all shell execution inside of your conditional, so the command is there, but it's not actually executed.

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@igorkotof igorkotof merged commit be1470b into master Nov 6, 2020
@igorkotof igorkotof deleted the feature/ssm-install branch November 6, 2020 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants