uberf-8301: improve desktop app update UX (#6808)

Signed-off-by: Alexey Zinoviev <[email protected]>
hcengineering · Oct 4, 2024 · fc9e15f · fc9e15f
1 parent 70a1666
commit fc9e15f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/desktop/src/main/start.ts b/desktop/src/main/start.ts
@@ -385,15 +385,20 @@ autoUpdater.on('update-available', (info: UpdateInfo) => {
         app.quit()
       }
       isUpdating = true
+      setDownloadProgress(0)
     })
 })
 
 autoUpdater.on('download-progress', (progressObj: ProgressInfo) => {
+  setDownloadProgress(progressObj.percent)
+})
+
+function setDownloadProgress (percent: number): void {
   if (mainWindow === undefined) return
 
-  mainWindow.setProgressBar(progressObj.percent / 100)
-  mainWindow.webContents.send('handle-update-download-progress', progressObj.percent)
-})
+  mainWindow.setProgressBar(percent / 100)
+  mainWindow.webContents.send('handle-update-download-progress', percent)
+}
 
 autoUpdater.on('update-downloaded', (info) => {
   // We have listeners that prevents the app from being exited on mac

diff --git a/packages/presentation/src/utils.ts b/packages/presentation/src/utils.ts
@@ -687,7 +687,7 @@ export function setPresentationCookie (token: string, workspaceId: string): void
   setToken('/files/' + workspaceId)
 }
 
-export const upgradeDownloadProgress = writable(0)
+export const upgradeDownloadProgress = writable(-1)
 
 export function setDownloadProgress (percent: number): void {
   if (Number.isNaN(percent)) {

diff --git a/plugins/guest-resources/src/components/GuestApp.svelte b/plugins/guest-resources/src/components/GuestApp.svelte
@@ -32,7 +32,7 @@
         <div class="antiPopup version-popup">
           <h1><Label label={workbench.string.ServerUnderMaintenance} /></h1>
           {$versionError}
-          {#if $upgradeDownloadProgress > 0}
+          {#if $upgradeDownloadProgress >= 0}
             <div class="mt-1">
               <Label label={workbench.string.UpgradeDownloadProgress} params={{ percent: $upgradeDownloadProgress }} />
             </div>

diff --git a/plugins/workbench-resources/src/components/WorkbenchApp.svelte b/plugins/workbench-resources/src/components/WorkbenchApp.svelte
@@ -68,8 +68,8 @@
               {$versionError}
             </div>
           {/if}
-          {#if $upgradeDownloadProgress > 0}
-            <div class="ml-2" class:mt-1={$versionError !== undefined}>
+          {#if $upgradeDownloadProgress >= 0}
+            <div class="ml-1" class:ml-2={$versionError === undefined}>
               <Label label={workbench.string.UpgradeDownloadProgress} params={{ percent: $upgradeDownloadProgress }} />
             </div>
           {/if}
@@ -85,7 +85,7 @@
                 <h1><Label label={workbenchRes.string.ServerUnderMaintenance} /></h1>
               {/if}
               {$versionError}
-              {#if $upgradeDownloadProgress > 0}
+              {#if $upgradeDownloadProgress >= 0}
                 <div class="mt-1">
                   <Label
                     label={workbench.string.UpgradeDownloadProgress}