Add plugin service descriptor paths to minion classpath #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use-case I have a spock test plugin in a separate Gradle source set.
I add the build output to the launch classpath.
The Gradle plugin sets hard
includeLaunchClasspath
tofalse
.The build output is added as
.../build/classes/java/pitest
and.../build/resources/pitest
,where the first contains the classes, the second the service descriptor.
The current logic searches the relevant services and then adds their code source
to the minion classpath.
This works fine if the class and descriptor are in one JAR how it usually is the case.
But for the described case, only the first path is added to the minion classpath
and then the Minion cannot find the configured test plugin.
There are two possible workarounds:
classPath
orclassPathFile
argument, so that they are always added to the minion classpath