Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify publisher type by embedding channel paramter in Bus trait/ #17

Merged
merged 5 commits into from
Apr 25, 2023
Merged

Simplify publisher type by embedding channel paramter in Bus trait/ #17

merged 5 commits into from
Apr 25, 2023

Conversation

hdoordt
Copy link
Owner

@hdoordt hdoordt commented Apr 24, 2023

Open question: can a user implement Bus with an incorrect Channel? If so, how can this be avoided?

@hdoordt hdoordt force-pushed the simplify-publisher-type branch from ccdaf91 to c58be6f Compare April 25, 2023 17:29
@hdoordt
Copy link
Owner Author

hdoordt commented Apr 25, 2023

Turns out it's rather hard to make it impossible to implement Bus with an incorrect Channel. However, because of the improved ergonomics, I decided that adding a note to the Bus trait should be enough.

@hdoordt hdoordt marked this pull request as ready for review April 25, 2023 18:02
@hdoordt hdoordt merged commit 4ca25d8 into eliminate-pin-project Apr 25, 2023
@hdoordt hdoordt deleted the simplify-publisher-type branch April 25, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hdoordt