-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Resource/CreateButton: Add cluster selector #2431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the cluster selector makes sense to be in the extraActions you created the other PR for, right?
As it's more discoverable for the user? Also, for now we may keep it single cluster selection, but it's be pretty cool to be able to select either the full cluster group or multiple individual clusters, so we could batch applies. But this can be added later.
So users can select which cluster to apply the resource to. Only shows the cluster selector if there is more than one cluster being viewed. For single cluster mode there is no change. Signed-off-by: René Dudfield <[email protected]> Co-authored-by: René Dudfield <[email protected]> Signed-off-by: Joaquim Rocha <[email protected]>
Yeah [https://github.com//pull/2428/files#diff-bd17d08e06e757d92d123c96d6fe154071e41f2dd53bfd1a096743023d66e8d2R67
Ok, I added a task here for that: #1699 (comment) |
9a7da1e
to
16cab9f
Compare
(rebased against main now that the #2428 is merged) |
I did misunderstand where the actions in this PR would end up. Clarified in DM. All good. |
So users can select which cluster to apply the resource to.
Only shows the cluster selector if there is more than one
cluster being viewed.
For single cluster mode there is no change.
Note: depends on this being merged:frontend: EditorDialog: Add optional actions property #2428