Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add cluster column to List views #2434

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

illume
Copy link
Collaborator

@illume illume commented Oct 16, 2024

These are not shown for single clusters.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 16, 2024
@illume illume added frontend Issues related to the frontend multi Multi cluster aggregated view labels Oct 16, 2024
@illume illume requested a review from a team October 16, 2024 09:31
@illume illume mentioned this pull request Oct 17, 2024
24 tasks
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have the cluster column right after the namespace? Right now, normally, the namespace col is after the resource name. So it reads like resource R in namespace N; having the cluster after the namespace would read like resource R in namespace N in cluster C.

These are not shown for single clusters.

Signed-off-by: René Dudfield <[email protected]>
@illume illume force-pushed the cluster-list-views branch 2 times, most recently from 9dd4c77 to 453fd94 Compare October 17, 2024 15:10
@illume
Copy link
Collaborator Author

illume commented Oct 17, 2024

@joaquimrocha I moved the cluster columns after name/namespace.

@illume illume requested review from joaquimrocha and a team October 18, 2024 12:05
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 18, 2024
@joaquimrocha joaquimrocha merged commit bb11d8e into main Oct 18, 2024
18 checks passed
@joaquimrocha joaquimrocha deleted the cluster-list-views branch October 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues related to the frontend lgtm This PR has been approved by a maintainer multi Multi cluster aggregated view size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants