frontend: fix websocket logs errors in tests #2754
Merged
+30
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrt10
changed the title
knrt10
force-pushed
the
websocket-frontend-tests-fix
branch
from
77e2c03 to
2ac5203
Compare
knrt10
changed the title
knrt10
force-pushed
the
websocket-frontend-tests-fix
branch
3 times, most recently
from
15dac73 to
6432c2e
Compare
illume
added
bug
We now mock console logs in tests and do not console errors for tests env. Signed-off-by: Kautilya Tripathi <[email protected]>
This prevents cascading failures where one broken listener could affect other WebSocket subscriptions, and ensures control messages are handled correctly before any data parsing attempts. Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10
force-pushed
the
websocket-frontend-tests-fix
branch
from
6432c2e to
39dfc3a
Compare
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now mock console logs in tests and do not console errors for tests env.
This:
v2websocket usagePart of:
Click to view Old logs
WebSocket error: Event { type: 'error', timeStamp: 1737091724622, target: WebSocket { listeners: { open: [Array], message: [Array], error: [Array], close: [Array] }, _onopen: [Function (anonymous)], _onmessage: [Function: bound handleWebSocketMessage], _onerror: [Function (anonymous)], _onclose: [Function (anonymous)], url: 'ws://localhost:4466/wsMultiplexer', protocol: '', binaryType: 'blob', readyState: 3 }, srcElement: WebSocket { listeners: { open: [Array], message: [Array], error: [Array], close: [Array] }, _onopen: [Function (anonymous)], _onmessage: [Function: bound handleWebSocketMessage], _onerror: [Function (anonymous)], _onclose: [Function (anonymous)], url: 'ws://localhost:4466/wsMultiplexer', protocol: '', binaryType: 'blob', readyState: 3 }, returnValue: true, isTrusted: false, eventPhase: 0, defaultPrevented: false, currentTarget: WebSocket { listeners: { open: [Array], message: [Array], error: [Array], close: [Array] }, _onopen: [Function (anonymous)], _onmessage: [Function: bound handleWebSocketMessage], _onerror: [Function (anonymous)], _onclose: [Function (anonymous)], url: 'ws://localhost:4466/wsMultiplexer', protocol: '', binaryType: 'blob', readyState: 3 }, cancelable: false, cancelBubble: false, bubbles: false } stderr | src/lib/k8s/api/v2/webSocket.test.ts > WebSocket Tests > useWebSocket hook > should handle connection errors WebSocket error: Event { type: 'error', timeStamp: 1737091724691, target: WebSocket { listeners: { open: [Array], message: [Array], error: [Array], close: [Array] }, _onopen: [Function (anonymous)], _onmessage: [Function: bound handleWebSocketMessage], _onerror: [Function (anonymous)], _onclose: [Function (anonymous)], url: 'ws://localhost:4466/wsMultiplexer', protocol: '', binaryType: 'blob', readyState: 3 }, srcElement: WebSocket { listeners: { open: [Array], message: [Array], error: [Array], close: [Array] }, _onopen: [Function (anonymous)], _onmessage: [Function: bound handleWebSocketMessage], _onerror: [Function (anonymous)], _onclose: [Function (anonymous)], url: 'ws://localhost:4466/wsMultiplexer', protocol: '', binaryType: 'blob', readyState: 3 }, returnValue: true, isTrusted: false, eventPhase: 0, defaultPrevented: false, currentTarget: WebSocket { listeners: { open: [Array], message: [Array], error: [Array], close: [Array] }, _onopen: [Function (anonymous)], _onmessage: [Function: bound handleWebSocketMessage], _onerror: [Function (anonymous)], _onclose: [Function (anonymous)], url: 'ws://localhost:4466/wsMultiplexer', protocol: '', binaryType: 'blob', readyState: 3 }, cancelable: false, cancelBubble: false, bubbles: false } WebSocket connection failed: Error: WebSocket connection failed at WebSocket.socket.onerror [as _onerror] (/Users/kautilya/dev/microsoft/headlamp/frontend/src/lib/k8s/api/v2/webSocket.ts:153:16) at /Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:859:16 at Array.forEach (<anonymous>) at WebSocket.dispatchEvent (/Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:855:13) at WebSocket.delayCallback (/Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:1530:14) at Timeout._onTimeout (/Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:757:58) at listOnTimeout (node:internal/timers:575:11) at processTimers (node:internal/timers:514:7) stderr | src/lib/k8s/api/v2/webSocket.test.ts > WebSocket Tests > WebSocket error handling > should handle invalid message format Failed to process WebSocket message: SyntaxError: Unexpected token 'i', "invalid json" is not valid JSON at JSON.parse (<anonymous>) at Object.handleWebSocketMessage (/Users/kautilya/dev/microsoft/headlamp/frontend/src/lib/k8s/api/v2/webSocket.ts:311:25) at /Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:859:16 at Array.forEach (<anonymous>) at Proxy.dispatchEvent (/Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:855:13) at /Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:2133:16 at Array.forEach (<anonymous>) at Server.emit (/Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:2121:16) at file:///Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/vitest-websocket-mock/dist/index.js:133:19 at act (file:///Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/vitest-websocket-mock/dist/index.js:33:5) stderr | src/lib/k8s/api/v2/webSocket.test.ts > WebSocket Tests > WebSocket error handling > should handle message callback errors in useWebSocket Failed to process WebSocket message: Error: Message processing failed at /Users/kautilya/dev/microsoft/headlamp/frontend/src/lib/k8s/api/v2/webSocket.test.ts:536:15 at mockCall (file:///Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/vitest/node_modules/@vitest/spy/dist/index.js:61:17) at spy (file:///Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/tinyspy/dist/index.js:45:80) at /Users/kautilya/dev/microsoft/headlamp/frontend/src/lib/k8s/api/v2/webSocket.ts:421:9 at Object.handleWebSocketMessage (/Users/kautilya/dev/microsoft/headlamp/frontend/src/lib/k8s/api/v2/webSocket.ts:339:15) at /Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:859:16 at Array.forEach (<anonymous>) at Proxy.dispatchEvent (/Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:855:13) at /Users/kautilya/dev/microsoft/headlamp/frontend/node_modules/mock-socket/dist/mock-socket.js:2133:16 at Array.forEach (<anonymous>)Testing
cd frontend && npm test webSocket.test.ts