[console] Implement statistics feature #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmolivas
reviewed
Apr 21, 2018
composer.json
Outdated
| @@ -52,7 +52,8 @@ | |||
| "symfony/yaml": "~2.8|~3.0", | |||
| "twig/twig": "^1.23.1", | |||
| "webflo/drupal-finder": "^1.0", | |||
| "webmozart/path-util": "^2.3" | |||
| "webmozart/path-util": "^2.3", | |||
| "guzzlehttp/guzzle": "^6.3" | |||
There was a problem hiding this comment.
- Update
drupal/console-coredependency"guzzlehttp/guzzle": "~6.1"as set ondrupal/consolerepository. - Remove
guzzlehttp/guzzlefromdrupal/consolerepository.
jmolivas
reviewed
Apr 21, 2018
src/Application.php
Outdated
|
|
||
| $dispatcher->addSubscriber( | ||
| new CalculateStatisticsListener( | ||
| $this->container->get('console.configuration_manager') |
There was a problem hiding this comment.
Remove this service and read config file directly from user home directory.
jmolivas
reviewed
Apr 21, 2018
| $finder | ||
| ->files() | ||
| ->name('*-pending.csv') | ||
| ->notName(date('Y_m_d').'-pending.csv') |
jmolivas
reviewed
Apr 21, 2018
| $languages = []; | ||
|
|
||
| foreach ($finder as $file) { | ||
| $file_content = array_filter(explode("\n", file_get_contents($file->getPathname()))); |
There was a problem hiding this comment.
replace \n with constant PHP_EOL
jmolivas
reviewed
Apr 21, 2018
| ->notName(date('Y_m_d').'-pending.csv') | ||
| ->in($path); | ||
|
|
||
| $statistics_keys = ['command', 'language', 'linesOfCode']; |
There was a problem hiding this comment.
replace statistics_keys with statisticsKeys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.