Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony dependency constraint #16

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

gapple
Copy link
Contributor

@gapple gapple commented Jul 24, 2017

Drupal 8.3 projects will continue to install Symfony 2.8 components where they are requirements of both drupal/core and drupal/console-extend-plugin due to Drupal 8.3's constraint of ~2.8, but components that are only requirements of drupal/console-extend-plugin may be updated to 3.x versions. This shouldn't be a problem as long as drupal/console-extend-plugin doesn't use any deprecated features in those 2.8 components.

@cburschka-pwc
Copy link

This still needs to be merged and released in order for 1.0.0-rc26 to work with symfony3 :)

Problem 1
- Installation request for drupal/console ^1.0.0-rc26 -> satisfiable by drupal/console[1.0.0-rc26].
- Conclusion: remove symfony/dependency-injection v3.2.8
- Conclusion: don't install symfony/dependency-injection v3.2.8
- drupal/console 1.0.0-rc26 requires drupal/console-extend-plugin ~0 -> satisfiable by drupal/console-extend-plugin[0.1.0, 0.2.0, 0.3.0, 0.4.0, 0.5.0, 0.6.0, 0.7.0, 0.8.0, 0.9.0, 0.9.1].
- drupal/console-extend-plugin 0.9.1 requires symfony/yaml >=2.7 <3.0 -> satisfiable by symfony/yaml[2.7.x-dev, 2.8.x-dev].
- symfony/yaml 2.7.x-dev conflicts with symfony/dependency-injection[v3.2.8].
- symfony/yaml 2.8.x-dev conflicts with symfony/dependency-injection[v3.2.8].
- Installation request for symfony/dependency-injection (locked at v3.2.8, required as ^3.2) -> satisfiable by symfony/dependency-injection[v3.2.8].

@jmolivas jmolivas merged commit f3bac23 into hechoendrupal:master Jul 28, 2017
@jmolivas
Copy link
Member

@gapple Thanks for your contribution, your PR was merged. This will be included on the next release.

@jmolivas
Copy link
Member

@cburschka-pwc Confirmed merging this PR an tagging a new release allows DrupalConsole composer require drupal/console:~1.0 to download. Thanks for testing and commenting.

@gapple gapple deleted the symfony-version branch July 28, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants