Skip to content

Commit

Permalink
Fix path directory and to create config files (#4154)
Browse files Browse the repository at this point in the history
  • Loading branch information
@gilbertomangones @enzolutions
gilbertomangones authored and enzolutions committed Sep 17, 2019
1 parent 7f023ab commit 37aeb5d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Command/Config/ExportCommand.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ protected function interact(InputInterface $input, OutputInterface $output)
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
$directory = $input->getOption('directory');
$drupal_root = $this->drupalFinder->getComposerRoot();
$directory = $drupal_root.'/'.$input->getOption('directory');
$tar = $input->getOption('tar');
$removeUuid = $input->getOption('remove-uuid');
$removeHash = $input->getOption('remove-config-hash');
Expand Down

1 comment on commit 37aeb5d

@lalop
Copy link
Contributor

@lalop lalop commented on 37aeb5d Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gilbertomangones @enzolutions this seems buggy for me.
$drupal_root is set twice with the same value, thenwe check if $directory is true each is always true since it's a concatenation with at least the character / then line 110 we try to create the directory $drupal_root."/".$directory but $directory is equal to $drupal_root.'/'.$input->getOption('directory') so you have twice drupal_root in it.
Maybe we can manage the directory argument the same it's done on the import command. I can work on that if need

Please sign in to comment.