Merge pull request #221 from jmolivas/config-debug-update

Config debug update
hechoendrupal · Oct 16, 2014 · 75c454f · 75c454f
2 parents cc7c33f + db0916f
commit 75c454f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/src/Command/ConfigDebugCommand.php b/src/Command/ConfigDebugCommand.php
@@ -32,27 +32,23 @@ protected function execute(InputInterface $input, OutputInterface $output)
   {
     $config_name = $input->getArgument('config-name');
 
-    $container = $this->getContainer();
-    $configFactory = $container->get('config.factory');
-
     $table = $this->getHelperSet()->get('table');
     $table->setlayout($table::LAYOUT_COMPACT);
 
     if (!$config_name) {
-      $this->getAllConfigurations($output, $table, $configFactory);
+      $this->getAllConfigurations($output, $table);
     }
     else {
-      $configStorage = $container->get('config.storage');
-      $this->getConfigurationByName($output, $table, $configStorage, $config_name);
+      $this->getConfigurationByName($output, $table, $config_name);
     }
   }
 
   /**
    * @param $output         OutputInterface
    * @param $table          TableHelper
-   * @param $configFactory  ConfigFactory
-     */
-  private function getAllConfigurations($output, $table, $configFactory){
+   */
+  private function getAllConfigurations($output, $table){
+    $configFactory = $this->getConfigFactory();
     $names = $configFactory->listAll();
     $table->setHeaders(['Name']);
     foreach ($names as $name) {
@@ -64,10 +60,10 @@ private function getAllConfigurations($output, $table, $configFactory){
   /**
    * @param $output         OutputInterface
    * @param $table          TableHelper
-   * @param $configStorage  ConfigStorage
    * @param $config_name    String
    */
-  private function getConfigurationByName($output, $table, $configStorage, $config_name){
+  private function getConfigurationByName($output, $table, $config_name){
+    $configStorage = $this->getConfigStorage();
     if ($configStorage->exists($config_name)) {
       $table->setHeaders([$config_name]);
 

diff --git a/src/Command/ContainerAwareCommand.php b/src/Command/ContainerAwareCommand.php
@@ -89,6 +89,14 @@ public function getValidator()
     return $this->getContainer()->get('console.validators');
   }
 
+  public function getConfigFactory(){
+    return $this->getContainer()->get('config.factory');
+  }
+
+  public function getConfigStorage(){
+    return $this->getContainer()->get('config.storage');
+  }
+
   public function validateModuleExist($module_name)
   {
     return $this->getValidator()->validateModuleExist($module_name, $this->getModules());