generate:entity:content is allowing duplicated "machine_name" to be entered

[vacho]

when I generate the entity "name_entity" and later I generate other entity with same name "name_entity" the code generated has duplicate.

And several other issues arise for failing at validate the id of the entity

[jmolivas]

After some research this is the proposed resolution

ContainerAwareCommand

• Add getEntityManager method

  public function getEntityManager(){
    return $this->getContainer()->get('entity.manager');
  }

• Update validateMachineName method

  public function validateMachineName($machine_name)
  {
    $machine_name = $this->getValidator()->validateMachineName($machine_name);

    if ($this->getEntityManager()->hasDefinition($machine_name)) {
      throw new \InvalidArgumentException(sprintf('Machine name "%s" is duplicated.', $machine_name));
    }

    return $machine_name;
  }

GeneratorEntityCommand

• Update interact method

if (!$entity_name) {
  $entity_name = $dialog->askAndValidate(
    $output,
    $dialog->getQuestion('Enter the entity name', $machine_name),
    function ($machine_name) {
      return $this->validateMachineName($machine_name);
    },
    false,
    $machine_name,
    null
  );
}

[jmolivas]

This is how the console looks like on execution

[jmolivas]

Fixed with PR #229

[jmolivas]

Fixed on release V0.2.19 https://github.com/hechoendrupal/DrupalAppConsole/releases/tag/0.2.19

Try updating project

$ composer update drupal/console