[generate:form] When I load a service, the console generate twice the service in create method

[igasi]

Problem/Motivation
I loaded 1 service and the console generate

Do you want to load services from the container (yes/no) [no]:
 > yes           


Type the service name or use keyup or keydown.
This is optional, press enter to continue

 Enter your service [ ]:
 > config.factory
 Enter your service [ ]:
 > 

Propose solution

Review the template for render this and remove double service in create method.

[igasi]

the config?

[omero]

It looks that the form template always injects the config.factory service https://github.com/hechoendrupal/DrupalConsole/blob/master/templates/module/src/Form/form.php.twig#L41

in the generate:form:config you need this service so, is correct, otherwise on a generic form is not necessary, any thoughts @jmolivas ?

[igasi]

Yes, in this case, is a generic form.

You're right, we are injecting at first but it is not used in the constructor.

[omero]

👍 for removing the line on the template at least for generate:form command.

[igasi]

This template only use for generate:form, or in other side?

[omero]

yes! is used on generate:form and generate:form:config commands

[igasi]

There are any way to differentiate between both?

For implements some thing this: (and send my PR)

{% if services is not empty %}
  public static function create(ContainerInterface $container) {
    return new static(
    {% if isGenerateFormConfigTemplate %}
      $container->get('config.factory'),
    {% endif %}
{{ serviceClassInjection(services) }}
    );
  }

{% endif %}

[omero]

Sorry my mistake, when looking the FormGenerator class https://github.com/hechoendrupal/DrupalConsole/blob/master/src/Generator/FormGenerator.php#L42, uses a different template for configuration forms, removing only the line can work

[igasi]

Nice, Thx.

[igasi]

PR sent.

[jmolivas]

Fixed with #2133