Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give version numbers for Drupal Console Launcher and Drupal Console #3164

Closed
nvaken opened this issue Feb 6, 2017 · 1 comment
Closed

Give version numbers for Drupal Console Launcher and Drupal Console #3164

nvaken opened this issue Feb 6, 2017 · 1 comment
Labels
enhancement

Comments

@nvaken
Copy link
Contributor

nvaken commented Feb 6, 2017 •
edited
Loading

When running drupal --version I see:

Drupal Console version 1.0.0-rc15

I expect to see both the launcher and the local instance version, something like:

Drupal Console version 1.0.0-rc15
Drupal Console Launcher version 1.0.0-rc15

This clears up possible confusion about if we're seeing the local Drupal Console version of the launcher's.

I might be wrong by expecting this, then please discard this issue.
nvaken pushed a commit to nvaken/drupal-console that referenced this issue May 4, 2017
Print launcher version, addresses hechoendrupal#3164
c3ba207
nvaken pushed a commit to nvaken/drupal-console-launcher that referenced this issue May 4, 2017
Introduce $launcherVersion in Application scope, addresses hechoendru…
a4404d3 
…pal/drupal-console#3164
@nvaken nvaken mentioned this issue May 4, 2017
Merged
jmolivas pushed a commit that referenced this issue May 5, 2017
@nvaken @jmolivas
Print launcher version, addresses #3164 (#3295)
ee8fb83
jmolivas pushed a commit to hechoendrupal/drupal-console-launcher that referenced this issue May 5, 2017
@nvaken @jmolivas
Introduce $launcherVersion in Application scope, addresses hechoendru…
cdd9e0b 
…pal/drupal-console#3164 (#97)
@nvaken
Copy link
Contributor Author

nvaken commented May 5, 2017

Above merged pull requests both fix this issue.

@nvaken nvaken closed this as completed May 5, 2017
This was referenced Jul 26, 2017
Closed
Closed
Merged
Closed
This was referenced Aug 4, 2017
Closed
Closed
Merged
This was referenced Aug 21, 2017
Closed
Closed
This was referenced Nov 8, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmolivas @nvaken