Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update:entities] Error message not printed correctly #3503

Closed
kylethebaker opened this issue Aug 30, 2017 · 1 comment
Closed

[update:entities] Error message not printed correctly #3503

kylethebaker opened this issue Aug 30, 2017 · 1 comment

Comments

@kylethebaker
Copy link
Contributor

Error message not printed correctly in update:entities command

[update:entities]

The $variables array from Error::decodeException is being passed directly to $io->info() without being destructured or turned into a message. This results in Array being printed in place of the error message leaving no indication of what the error actually was.

Error::decodeException return type

Call inside of command

How to reproduce

You can confirm this by adding a line throw new EntityExceptionStorage("test") inside of the try block.

  • Drupal version (8.3.7)
  • Console version (confirmed on 1.0.0-rc25 and current master).

Solution

The pieces of the $variables array need to be put into a string message.

@jmolivas
Copy link
Member

PR #3504 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants