Fix #3503: prints exception variable contents #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylethebaker
changed the title
|
#3503 Adding this here since I used the wrong issue in the title initially |
|
@kylethebaker Thanks for your contribution, your PR was merged. This will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are other approaches here, but this is the most straightforward. Initially I was using
Error::renderExceptionSafewhich will render the exception into a string, but it contains html markup which doesn't play nice with console. The markup can then be passed toDrupal\Component\Render\PlainTextOutput::renderFromHtmlwhich will strip the tags. But ultimately it's just a round about way to accomplish what I have here._drupal_log_exceptionusesstrtrso I took inspiration from there. If there is a more "drupal" way to render the exception contents into a plaintext string then that might be better.