Minor fix: Fixed Module generation with Controller option=YES #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @bearsite and for noticing it was not generating the controller May you change the code to something like this same as in Controller generation https://github.com/hechoendrupal/DrupalAppConsole/blob/master/src/Command/GeneratorControllerCommand.php#L118 I will add comments on the suggested lines |
| $class_machine_name = 'default_controller'; | ||
| $parameters = array( | ||
| 'class_name' => $class_name, | ||
| // 'services' => $services, |
|
Thank you @jmolivas. Please check if I applied your comments correctly. |
|
Already tested and works fine thanks I will go ahead and merge the PR |
jmolivas
added a commit
that referenced
this pull request
Jul 3, 2014
Minor fix: Fixed Module generation with Controller option=YES
|
Thanks for the contribution @bearsite 👍 |
g3r4
pushed a commit
to g3r4/drupal-console
that referenced
this pull request
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed parameters for Controller template in ModuleGenerator.
Fixed creating of Directory structure in ModuleGenerator.