Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block.php.twig #206

Merged
merged 2 commits into from
Sep 23, 2014
Merged

Update block.php.twig #206

merged 2 commits into from
Sep 23, 2014

Conversation

azarzag
Copy link
Contributor

@azarzag azarzag commented Sep 22, 2014

Fixes BlockBase class path.

Fixes BlockBase class path.
@dmouse
Copy link
Member

dmouse commented Sep 22, 2014

Hi @azarzag thanks for your help, I am check the correct namespace to the BlockBase class and is Drupal\Core\Block\BlockBase Please change this for merge it.

D

@@ -9,7 +9,7 @@ namespace Drupal\{{module}}\Plugin\Block;
{% endblock %}

{% block use_class %}
use Drupal\block\BlockBase;
use Drupal\Core\block\BlockBase;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the correct is use Drupal\Core\Block\BlockBase

@azarzag
Copy link
Contributor Author

azarzag commented Sep 23, 2014

Should be ready to go.

@jmolivas
Copy link
Member

Thanks @azarzag, seems good to me now, need to do some test it in order to merge PR, I will try to assign some time today/tomorrow and give you some feedback.

jmolivas added a commit that referenced this pull request Sep 23, 2014
@jmolivas jmolivas merged commit 18c903d into hechoendrupal:master Sep 23, 2014
@jmolivas
Copy link
Member

Merged, thanks for this PR @azarzag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants