-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2542 Add taxonomy delete command. #2543
Conversation
…used in other taxonomy related commands
added an additional delete all command, though very similar it is a separate command as deleting every term for every taxonomy should be an explicit command due to high risk level |
|
||
use Symfony\Component\Console\Input\InputInterface; | ||
use Symfony\Component\Console\Output\OutputInterface; | ||
use Symfony\Component\Console\Command\Command as BaseCommand; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twhiston There is no longer need to register this alias. Please update this line
use Symfony\Component\Console\Command\Command as BaseCommand;
as this
+use Symfony\Component\Console\Command\Command;
@twhiston and the last missing piece is: Register command class as a service at
|
@twhiston how about instead of having two commands, why not only have one command and execute as:
Having to pass |
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…nd, refactor and change command to taxonomy:term:delete to make clear that this does not delete the taxonomy itself.
Sorry this took a while to do, but it should be ok now. |
any update on this PR? can it be included? |
@twhiston Now that we have the RC releases running I will be able to check and test this PR. |
@twhiston Thanks for your contribution, your PR was merged. This will be included on the next release. |
Added a command to delete all terms in a taxonomy. Deletion routine is a trait so can be re-used in other taxonomy deletion situations.