Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix to autoload if console is installed globally or within project #2786

Merged
merged 1 commit into from
Oct 16, 2016
Merged

Conversation

s3than
Copy link
Contributor

@s3than s3than commented Oct 10, 2016

Issue

Add's a check to the autoload to check whether drupal console is installed globally or within the project itself.

@jmolivas
Copy link
Member

@s3than Thanks for the PR. this PR fixes the autoload when installing DrupalConsole via composer global require?

@s3than
Copy link
Contributor Author

s3than commented Oct 11, 2016

I'm in the process of checking multiple install moment

  1. composer require drupal/console (with default bin location)
  2. composer require drupal/console (with custom bin location)
  3. composer require drupal/console (with custom bin location and custom core location)

If you would like to label as WIP I'll advise once I've completed the installs and tests.

@jmolivas jmolivas changed the title Fix to autoload if console is installed globally or within project [WIP] Fix to autoload if console is installed globally or within project Oct 15, 2016
@jmolivas jmolivas changed the title [WIP] Fix to autoload if console is installed globally or within project WIP: Fix to autoload if console is installed globally or within project Oct 15, 2016
@jmolivas
Copy link
Member

I will merge this to work on the --root discovery for this repo as in the Drupal Console Launcher https://github.com/hechoendrupal/drupal-console-launcher/blob/master/bin/drupal.php#L33

@jmolivas jmolivas merged commit 24e84dd into hechoendrupal:master Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants