[site:statistics] command fails when comment module is uninstalled. Fix #2744 #2799
Conversation
| try { | ||
| $entityQuery = $this->entityQuery->get('comment')->count(); | ||
| } catch (PluginNotFoundException $e) { | ||
| return 0; |
There was a problem hiding this comment.
@daydiff Thanks for the PR
if any error the CLI application should a value greater than 0 updating to 1 will do the work here.
There was a problem hiding this comment.
But it is not the value CLI application returns, but the value of comments which is 0 when "Comment" module is not installed. Btw I agree, that it would be better to not catch exception but prevent it. I can replace catch block with something like this:
if (!\Drupal::moduleHandler()->moduleExists('comment')) {
return 0;
}What do you think about such changes?
There was a problem hiding this comment.
I replaced try-catch block so it is no exception now.
There was a problem hiding this comment.
My bad, but like this better value 0 instead of PluginNotFoundException
jmolivas
changed the title
|
@daydiff Thanks for your contribution, your PR was merged. This will be included on the next release. |
fix failing command [site:statistics] when comment module is uninstalled