[rest:enable] Fix enable rest resource #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue in #2912 |
edutrul
changed the title
edutrul
changed the title
|
This is ready for review!! @enzolutions |
|
Thanks @edutrul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
for the following reasons
GET, POST, DELETE, PATCH are NOT states! they are METHODS see:
and also translation in English is:
"REST States to enable for Rest resource:"
which should be "METHODS to enable for Rest resource"
I'll make sure I do PR for sure!!
So the above is the reason why I am changing "states" to "method"
Please this PR is still in PROGRESS so DO NOT merge till I finish it! thanks!
UPDATE!:
Finally fix is already done!!