-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new config:import:list and config:export:list commands. Fix no return on configImport method for config:import:single command #2965
Conversation
… directory and config-list-file parameter/argument
@bpresles I like this idea but since we have |
@jmolivas Once you tell me you preference I'll work on it and create a new pull request (it will be cleaner). |
@bpresles I think we can do something like this to merge with current My first idea or recommended approach is to change ExportSingleCommand
Add documentation how to use it:
NOTE: A chain command can read a YAML file and execute one or multiple commands previously defined on that YAML file. Examples: |
@bpresles still interested to make this happen? |
@jmolivas Yes sure. I didn't have much time these days to work on it. I'll look at it this week end. |
@jmolivas Just to keep you informed, I didn't have much time this week end finally. I hope to be able to work on it and finish it for the end of the week at most. |
4402f05
to
a23202f
Compare
…e configs with the config:import:single and config:export:single commands
@jmolivas |
@bpresles Thanks for refactoring I have some comments:
|
I saw some other old issues to fix like, argument names ons is called |
I will go ahead and have this merged and I will send a PR with mentioned fixes. |
Added 2 commands:
config:import:list
Takes a YAML file with list of config names to import. Allow to import restricted list of config names easily (rather than doing multiple config:import:single for each config name)
config:export:list
Takes a YAML file with list of config names to export. Allow to export restricted list of config names easily (rather than doing multiple config:export:single for each config name)
Also includes a fix in configImport method of config:import:single command that doesn't return boolean on success (making the success message not displayed).