[config:import] return exit code on error (#3083) #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more accurate than printing it after the import has finished.
jmolivas
reviewed
Jan 10, 2017
| $io->info($this->trans('commands.config.import.messages.importing')); | ||
| $config_importer->import(); | ||
| return TRUE; |
There was a problem hiding this comment.
The execute() function is expected to return an exit code (1 on failure, 0 or nothing on success), while the private configImport() function is expected to return a success boolean (TRUE on success, FALSE or nothing on failure). So it's weird, but consistent with the current usage...
There was a problem hiding this comment.
My bad, this is a private scope function. not the execute function.
|
@cburschka Thanks for your contribution, your PR was merged. This will be included on the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.