Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revisions tab for generated content entity #3139

Merged
merged 3 commits into from
Feb 5, 2017

Conversation

derhasi
Copy link
Contributor

@derhasi derhasi commented Jan 30, 2017

When using the generated content entity, errors occur, when displaying the revisions tab for that entity type.

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "MYENTITY.revision_revert" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 187 of [...]/core/lib/Drupal/Core/Routing/RouteProvider.php).
Symfony\Component\Routing\Exception\RouteNotFoundException: Route "MYENTITY.revision_revert_confirm" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 187 of [...]/core/lib/Drupal/Core/Routing/RouteProvider.php).

In addition for revisionable but not translatable entities, no revisions are displayed at all, as _ revision_translation_affected_ is not set. Therefore I guess it is better to remove the revision_translation_affected when entity is not translatable.

@jmolivas jmolivas modified the milestone: 1.0.0-rc16 Feb 3, 2017
@jmolivas jmolivas merged commit f5431db into hechoendrupal:master Feb 5, 2017
@jmolivas
Copy link
Member

jmolivas commented Feb 5, 2017

@derhasi Thanks for your contribution, your PR was merged. This will be included on the next release.

@derhasi derhasi deleted the patch-1 branch February 5, 2017 20:06
@jchatard
Copy link

Hi,

I'm not sure that updating this issue is relevant, but using drupal console 1.0.0-rc16 to generate an entity type with revision support enabled seems to give me the same error when clicking the revision tab:

Exception: "Route "entity.MY_ENTITY_TYPE.revision_revert" does not exist

But as I understand it, this issue with the PR merged in master 10 days ago and rc16 released 6 days ago, I was thinking this was now working.

Did I miss something? :-D

Thank you,
Jérémy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants