[console] Add missing return error codes.

src/Annotations/DrupalCommand.php

@@ -12,7 +12,6 @@
  * @Annotation
  * @Target("CLASS")
  */
-
 class DrupalCommand
 {
     /**

src/Command/Config/EditCommand.php

@@ -97,7 +97,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if (!$configName) {
             $io->error($this->trans('commands.config.edit.messages.no-config'));
 
-            return;
+            return 1;
         }
 
         try {
@@ -106,7 +106,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         } catch (IOExceptionInterface $e) {
             $io->error($this->trans('commands.config.edit.messages.no-directory').' '.$e->getPath());
 
-            return;
+            return 1;
         }
         if (!$editor) {
             $editor = $this->getEditor();
@@ -122,9 +122,13 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $config->save();
             $fileSystem->remove($configFile);
         }
+
         if (!$process->isSuccessful()) {
             $io->error($process->getErrorOutput());
+            return 1;
         }
+
+        return 0;
     }
 
     protected function interact(InputInterface $input, OutputInterface $output)

src/Command/ContainerDebugCommand.php

@@ -80,7 +80,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
             return 0;
         } else {
-
             $tableHeader = [];
             if ($service) {
                 $tableRows = $this->getServiceDetail($service);
@@ -101,13 +100,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
         return 0;
     }
 
-    private function getCallbackReturnList($service, $method, $args) {
-
-        if ($args != NULL) {
-            $parsedArgs = json_decode($args, TRUE);
-            if (!is_array($parsedArgs)) $parsedArgs = explode(",", $args);
+    private function getCallbackReturnList($service, $method, $args)
+    {
+        if ($args != null) {
+            $parsedArgs = json_decode($args, true);
+            if (!is_array($parsedArgs)) {
+                $parsedArgs = explode(",", $args);
+            }
         } else {
-            $parsedArgs = NULL;
+            $parsedArgs = null;
         }
         $serviceInstance = \Drupal::service($service);
 
@@ -124,7 +125,7 @@ private function getCallbackReturnList($service, $method, $args) {
             '<fg=green>'.$this->trans('commands.container.debug.messages.class').'</>',
             '<fg=yellow>'.get_class($serviceInstance).'</>'
         ];
-        $methods = array($method);
+        $methods = [$method];
         $this->extendArgumentList($serviceInstance, $methods);
         $serviceDetail[] = [
             '<fg=green>'.$this->trans('commands.container.debug.messages.method').'</>',
@@ -133,10 +134,10 @@ private function getCallbackReturnList($service, $method, $args) {
         if ($parsedArgs) {
             $serviceDetail[] = [
                 '<fg=green>'.$this->trans('commands.container.debug.messages.arguments').'</>',
-                json_encode($parsedArgs, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE )
+                json_encode($parsedArgs, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE)
             ];
         }
-        $return = call_user_func_array(array($serviceInstance,$method), $parsedArgs);
+        $return = call_user_func_array([$serviceInstance,$method], $parsedArgs);
         $serviceDetail[] = [
             '<fg=green>'.$this->trans('commands.container.debug.messages.return').'</>',
             json_encode($return, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE)
@@ -152,10 +153,11 @@ private function getServiceList()
         foreach ($serviceDefinitions as $serviceId => $serviceDefinition) {
             $services[] = [$serviceId, $serviceDefinition->getClass()];
         }
-        usort($services, array($this, 'compareService'));
+        usort($services, [$this, 'compareService']);
         return $services;
     }
-    private function compareService($a, $b) {
+    private function compareService($a, $b)
+    {
         return strcmp($a[0], $b[0]);
     }
 
@@ -208,16 +210,17 @@ private function getServiceDetail($service)
 
         return $serviceDetail;
     }
-    private function extendArgumentList($serviceInstance, &$methods) {
+    private function extendArgumentList($serviceInstance, &$methods)
+    {
         foreach ($methods as $k => $m) {
             $reflection = new \ReflectionMethod($serviceInstance, $m);
             $params = $reflection->getParameters();
-            $p = array();
+            $p = [];
 
-            for ($i = 0; $i < count($params) ; $i++) {
+            for ($i = 0; $i < count($params); $i++) {
                 if ($params[$i]->isDefaultValueAvailable()) {
                     $defaultVar = $params[$i]->getDefaultValue();
-                    $defaultVar = " = <fg=magenta>".str_replace(array("\n","array ("), array("", "array("), var_export($def,true)).'</>';
+                    $defaultVar = " = <fg=magenta>".str_replace(["\n","array ("], ["", "array("], var_export($def, true)).'</>';
                 } else {
                     $defaultVar = '';
                 }
@@ -230,8 +233,11 @@ private function extendArgumentList($serviceInstance, &$methods) {
                 } else {
                     $defaultType = '';
                 }
-                if ($params[$i]->isPassedByReference()) $parameterReference = '<fg=yellow>&</>';
-                else $parameterReference = '';
+                if ($params[$i]->isPassedByReference()) {
+                    $parameterReference = '<fg=yellow>&</>';
+                } else {
+                    $parameterReference = '';
+                }
                 $p[] = $defaultType.$parameterReference.'<fg=red>'.'$</><fg=red>'.$params[$i]->getName().'</>'.$defaultVar;
             }
             if ($reflection->isPublic()) {

src/Command/Generate/AuthenticationProviderCommand.php

@@ -93,14 +93,16 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $module = $input->getOption('module');
         $class = $input->getOption('class');
         $provider_id = $input->getOption('provider-id');
 
         $this->generator->generate($module, $class, $provider_id);
+
+        return 0;
     }
 
     protected function interact(InputInterface $input, OutputInterface $output)

src/Command/Generate/BreakPointCommand.php

@@ -118,7 +118,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $validators = $this->validator;
@@ -132,6 +132,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $breakpoints,
             $machine_name
         );
+
+        return 0;
     }
 
     /**

src/Command/Generate/CacheContextCommand.php

@@ -108,7 +108,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $module = $input->getOption('module');

src/Command/Generate/CommandCommand.php

@@ -144,7 +144,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io, $yes)) {
-            return;
+            return 1;
         }
 
         // @see use Drupal\Console\Command\Shared\ServicesTrait::buildServices

src/Command/Generate/ControllerCommand.php

@@ -137,10 +137,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io, $yes)) {
-            return;
+            return 1;
         }
 
-        $learning = $input->hasOption('learning')?$input->getOption('learning'):false;
         $module = $input->getOption('module');
         $class = $input->getOption('class');
         $routes = $input->getOption('routes');
@@ -164,6 +163,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // Run cache rebuild to see changes in Web UI
         $this->chainQueue->addCommand('router:rebuild', []);
+
+        return 0;
     }
 
     /**

src/Command/Generate/EntityBundleCommand.php

@@ -15,7 +15,6 @@
 use Drupal\Console\Command\Shared\ModuleTrait;
 use Drupal\Console\Command\Shared\ServicesTrait;
 use Drupal\Console\Core\Command\Shared\CommandTrait;
-use Drupal\Console\Generator\ContentTypeGenerator;
 use Drupal\Console\Generator\EntityBundleGenerator;
 use Drupal\Console\Core\Style\DrupalStyle;
 use Drupal\Console\Extension\Manager;
@@ -28,7 +27,6 @@ class EntityBundleCommand extends Command
     use ServicesTrait;
     use ConfirmationTrait;
 
-
     /**
      * @var Validator
      */
@@ -93,18 +91,19 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $module = $input->getOption('module');
         $bundleName = $input->getOption('bundle-name');
         $bundleTitle = $input->getOption('bundle-title');
-        $learning = $input->hasOption('learning')?$input->getOption('learning'):false;
 
         $generator = $this->generator;
         //TODO:
-        //$generator->setLearning($learning);
+        //        $generator->setLearning($learning);
         $generator->generate($module, $bundleName, $bundleTitle);
+
+        return 0;
     }
 
     /**

src/Command/Generate/EventSubscriberCommand.php

@@ -125,7 +125,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $module = $input->getOption('module');

src/Command/Generate/FormAlterCommand.php

@@ -165,7 +165,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $module = $input->getOption('module');
@@ -193,6 +193,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ->generate($module, $formId, $inputs, $this->metadata);
 
         $this->chainQueue->addCommand('cache:rebuild', ['cache' => 'discovery']);
+
+        return 0;
     }
 
     protected function interact(InputInterface $input, OutputInterface $output)

src/Command/Generate/HelpCommand.php

@@ -97,7 +97,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $module = $input->getOption('module');
@@ -118,6 +118,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ->generate($module, $description);
 
         $this->chainQueue->addCommand('cache:rebuild', ['cache' => 'discovery']);
+
+        return 0;
     }
 
     protected function interact(InputInterface $input, OutputInterface $output)

src/Command/Generate/ModuleCommand.php

@@ -177,7 +177,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io, $yes)) {
-            return;
+            return 1;
         }
 
         $module = $this->validator->validateModuleName($input->getOption('module'));
@@ -214,6 +214,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $test,
             $twigTemplate
         );
+
+        return 0;
     }
 
     /**
@@ -233,7 +235,7 @@ protected function interact(InputInterface $input, OutputInterface $output)
         } catch (\Exception $error) {
             $io->error($error->getMessage());
 
-            return;
+            return 1;
         }
 
         if (!$module) {

src/Command/Generate/ModuleFileCommand.php

@@ -76,7 +76,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io, $yes)) {
-            return;
+            return 1;
         }
 
         $machine_name =  $input->getOption('module');

src/Command/Generate/PluginCKEditorButtonCommand.php

@@ -123,7 +123,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $module = $input->getOption('module');
@@ -138,6 +138,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ->generate($module, $class_name, $label, $plugin_id, $button_name, $button_icon_path);
 
         $this->chainQueue->addCommand('cache:rebuild', ['cache' => 'discovery'], false);
+
+        return 0;
     }
 
     protected function interact(InputInterface $input, OutputInterface $output)

src/Command/Generate/PluginConditionCommand.php

@@ -131,7 +131,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $module = $input->getOption('module');
@@ -147,6 +147,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ->generate($module, $class_name, $label, $plugin_id, $context_definition_id, $context_definition_label, $context_definition_required);
 
         $this->chainQueue->addCommand('cache:rebuild', ['cache' => 'discovery']);
+
+        return 0;
     }
 
     protected function interact(InputInterface $input, OutputInterface $output)

src/Command/Generate/PluginFieldCommand.php

@@ -155,7 +155,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @see use Drupal\Console\Command\Shared\ConfirmationTrait::confirmGeneration
         if (!$this->confirmGeneration($io)) {
-            return;
+            return 1;
         }
 
         $this->chainQueue
@@ -196,6 +196,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             );
 
         $this->chainQueue->addCommand('cache:rebuild', ['cache' => 'discovery'], false);
+
+        return 0;
     }
 
     protected function interact(InputInterface $input, OutputInterface $output)