Allow inherited ModuleInstaller classes to InstallDependencyCommand. #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exactly we should be injecting interfaces instead of concrete classes. |
|
@dpagini Thanks for your contribution, your PR was merged. This will be included on the next release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting a Drupal Console error in my project b/c I'm extending the Drupal "ModuleInstaller" class. My code is then passing in my overridden class via services to Drupal Console. I'm not 100% sure this is right, but this feels like it should be accepting the ModuleInstallerInterface instead of just ModuleInstaller. I'm not that familiar with "ProxyClass"es which is what I'm removing, so I'm not confident this is definitely correct. Please advise if you don't think this is an appropriate bugfix.
Other:
@paramto constructor comment.