Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create:comments] Add validation of node id. Fix code structure. Replace the wrong method #3669

Merged

Conversation

LOBsTerr
Copy link
Member

@LOBsTerr LOBsTerr commented Jan 9, 2018

  • Add validation of node id.
  • Fix code structure.
  • Replace the wrong method getTitle with getSubject.
  • Order use statements alphabetically

…od getTitle with getSubject. Order use statements alphabetically
@jmolivas jmolivas changed the title Add validation of node id. Fix code structure. Replace the wrong meth… [create:comments] Add validation of node id. Fix code structure. Replace the wrong method Jan 10, 2018
@jmolivas jmolivas modified the milestone: 1.4.1 Jan 10, 2018
@jmolivas jmolivas merged commit 40c3bc7 into hechoendrupal:master Jan 10, 2018
@jmolivas
Copy link
Member

@LOBsTerr Thanks for your contribution, your PR was merged. This will be included in the next release.

@LOBsTerr LOBsTerr deleted the issue-3628-warning-create-comment branch January 18, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants