Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Refactor theme commands. Fix #3696 #3703

Merged
merged 5 commits into from
Jan 23, 2018
Merged

[theme] Refactor theme commands. Fix #3696 #3703

merged 5 commits into from
Jan 23, 2018

Conversation

LOBsTerr
Copy link
Member

  1. Created the base class
  2. Created the methods to display info and error messages
  3. Created the methods handling available, unavailable and uninstalled themes
  4. Created the common method to get theme argument
  5. And other improvements, which simplify the main logic and remove duplications

@LOBsTerr LOBsTerr mentioned this pull request Jan 17, 2018
Closed
@jmolivas jmolivas changed the title Issue 3696 refactor theme command [Theme] Refactor theme commands. Jan 20, 2018
@jmolivas jmolivas changed the title [Theme] Refactor theme commands. [Theme] Refactor theme commands. Fix #3696 Jan 20, 2018
@jmolivas jmolivas added this to the 1.6.0 milestone Jan 22, 2018
@jmolivas
Copy link
Member

@LOBsTerr is this ready to be tested or still WIP?

@LOBsTerr
Copy link
Member Author

@jmolivas It is finished. You can test it

@jmolivas
Copy link
Member

@LOBsTerr cold you sync with the master branch?

@jmolivas jmolivas changed the title [Theme] Refactor theme commands. Fix #3696 [theme] Refactor theme commands. Fix #3696 Jan 23, 2018
@LOBsTerr
Copy link
Member Author

@jmolivas All conflicts have been resolved.

@jmolivas jmolivas merged commit bac0de0 into hechoendrupal:master Jan 23, 2018
@jmolivas
Copy link
Member

@LOBsTerr Thanks for your contribution, your PR was merged. This will be included in the next release.

@LOBsTerr LOBsTerr deleted the issue-3696-refactor-theme-command branch January 24, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LOBsTerr @jmolivas