Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config:export:content:type] Fixed conflicts and add missing services #4036

Merged
merged 3 commits into from
May 14, 2019
Merged

Conversation

hjuarez20
Copy link
Contributor

This PR is an extension of #3846 and resolved missing code and conflicts

@LOBsTerr
Copy link
Member

@enzolutions I have reverted my changes, which uses "config:export:entity" as chain command.
I have added it. In order to reduce duplication and make it more easier to export any entity.

$this->chainQueue->addCommand(
            'config:export:entity', [
                'entity-type' => 'node_type',
                'bundle' => $contentType,
                '--module' => $module,
                '--optional-config' => $optionalConfig,
                '--remove-uuid' => $removeUuid,
                '--remove-config-hash' => $removeHash
            ]
        );

@enzolutions
Copy link
Contributor

Hi, @LOBsTerr Do you mean we need to revert this merge? and you will create another PR to introduce your suggestion?

@LOBsTerr
Copy link
Member

I will create a new pr, with the current improvements and my changes

@enzolutions
Copy link
Contributor

Awesome @LOBsTerr

@LOBsTerr
Copy link
Member

@enzolutions Everything should be here: #4044

More information in my new PR: #4045

@enzolutions
Copy link
Contributor

Awesome, we will review an merge soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants