Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site:status] improvements #4063

Merged
merged 25 commits into from
May 29, 2019
Merged

[site:status] improvements #4063

merged 25 commits into from
May 29, 2019

Conversation

mondrake
Copy link
Contributor

  1. I find the current output of ss a bit too verbose - greatly prefer the more succint results in 1.8.0. So I am proposing to print out the description only if verbose mode is on i.e. the -v flag is set -> drupal site:status -v
  2. Color coding errors and warnings according to severity of the requirement. This makes ss consistent with Drupal core's 'Status report' webpage.
  3. Skip reporting empty keys in the database connection options.

See new results below (non-verbose)
Schermata 2019-05-24 alle 21 27 07

@enzolutions
Copy link
Contributor

@mondrake this is ready to review, to see if we could include in the next release 1.9.0 next week?

@mondrake
Copy link
Contributor Author

yea, no more changes from my side

src/Command/Site/StatusCommand.php Outdated Show resolved Hide resolved
src/Command/Site/StatusCommand.php Outdated Show resolved Hide resolved
@mondrake
Copy link
Contributor Author

Done, thanks for review @harold20

@mondrake
Copy link
Contributor Author

Please see also hechoendrupal/drupal-console-en#233

@hjuarez20
Copy link
Contributor

Hey @mondrake that new commit has problems related with the "if", You forget close the condition. Could you fix it?

@mondrake
Copy link
Contributor Author

Sorry. Fixed and did a bit more cleaning.

@enzolutions
Copy link
Contributor

Thanks @mondrake

@enzolutions enzolutions merged commit df8b95b into hechoendrupal:master May 29, 2019
@mondrake mondrake deleted the site-status branch May 29, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants