Generate revisional entity content is broken #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@clemens-tolboom this is ready to test? |
? ... we just need the semi-colon back right? |
|
Sure, I just want to confirm, there is nothing else pending to commit, we will check and merge soon. Thanks for your contributions. |
|
Are there tests available (for checking generated code)? ... I'm just busy doning #4138 :-) |
|
Sadly, we don't have support for that kind of tests :S |
|
@enzolutions I tried to test through #3939 ... can you help with that? |
clemens-tolboom
added a commit
to clemens-tolboom/DrupalConsole
that referenced
this pull request
Aug 24, 2019
|
Thanks @clemens-tolboom |
enzolutions
pushed a commit
that referenced
this pull request
Sep 6, 2019
* Add command option has-bundle-permissions and use on entity. * Add (Entity}Permissions.php file. * Add permission_callback to permissions.yml file. * Added fix from #4139 as it hurts. * Add own permissions checks.
enzolutions
pushed a commit
that referenced
this pull request
Oct 10, 2019
* Update services.yml * Fix Travis tests * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * 1 * Ensure $roles is an array when creating users. (#4134) This prevents an error from being thrown when constructing the success message. See #4133. * Generate revisional entity content is broken (#4139) * Add bundle permissions for content entity (#4138) * Add command option has-bundle-permissions and use on entity. * Add (Entity}Permissions.php file. * Add permission_callback to permissions.yml file. * Added fix from #4139 as it hurts. * Add own permissions checks. * Add --default option to database:add (#4143) This option allows to set the database as the default one instead of adding a new database in addition to the default one. See: #4142 * Update version to 1.9.3 (#4144) * Update version to 1.9.3 * Remove Module/InstallCommand::moduleRequirement * Remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lack of ; was introduced in dd64922