Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hang when Game::TICKS_PER_SECOND is 0 #99

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Fix hang when Game::TICKS_PER_SECOND is 0 #99

merged 3 commits into from
Sep 23, 2019

Conversation

hecrj
Copy link
Owner

@hecrj hecrj commented Sep 23, 2019 •
edited
Loading

Fixes #96.

The game will still tick in this case after approximately 584942417355.072 years in most platforms. I think this is acceptable.

@hecrj hecrj added the bug Something isn't working label Sep 23, 2019
@hecrj hecrj added this to the 0.4.0 milestone Sep 23, 2019
@hecrj hecrj self-assigned this Sep 23, 2019
@hecrj hecrj mentioned this pull request Sep 23, 2019
Closed
@hecrj hecrj merged commit 7197ea3 into master Sep 23, 2019
@hecrj hecrj deleted the fix/no-ticks-per-second branch September 24, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hecrj hecrj

Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

TICKS_PER_SECOND = 0 pegs the CPU
1 participant
@hecrj