Add ascii/latin1/unicode character generators #96
Conversation
src/Hedgehog/Gen.fs
Outdated
| @@ -354,7 +368,7 @@ module Gen = | |||
|
|
|||
| /// Generates a random string. | |||
| let string : Gen<string> = | |||
| choice [alphaNum; charBounded] |> string' | |||
| choice [alphaNum; unicodeAll] |> string' | |||
There was a problem hiding this comment.
Maybe this should be just unicode given the surrogates won't be a legal string unless they're combined correctly? (sorry I don't know that much about unicode surrogates, but I get the impression this wouldn't be a valid string as such)
There was a problem hiding this comment.
Hmm... True, unicode is a better default, I'll change it.
And, I think, we need something similar in the Haskell version? Right now it uses min/max bounds of char, no?
There was a problem hiding this comment.
I don't think there is a haskell version, the haskell Gen.string takes a Gen<char> as an argument
There was a problem hiding this comment.
hmm, I wonder if we should just rename string' -> string and delete this, let people make their own choices for characters?
There was a problem hiding this comment.
That was exactly what I was thinking right now... We're going to have Gen.fs in line with the Haskell one anyway, so good idea. I'll undo 4979fb5 also.
There was a problem hiding this comment.
OK, I just pushed f39c328.
… the specified character generator. This brings the Gen module closer to the Haskell version. See also: #96 (comment)
|
👍 sorry for the delay |
ghost
modified the milestones:
In line with hedgehogqa/haskell-hedgehog#73.