Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for passing options into iconv-lite #2

Merged
merged 3 commits into from
May 24, 2016
Merged

Added support for passing options into iconv-lite #2

merged 3 commits into from
May 24, 2016

Conversation

rickihastings
Copy link
Contributor

No description provided.

@heldinz
Copy link
Owner

heldinz commented May 13, 2016

Thanks, looks great! Could you just change the option names to iconv, decode and encode?

@rickihastings
Copy link
Contributor Author

No problem, done. Thanks

@coveralls
Copy link

coveralls commented May 15, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 97.895% when pulling decc952 on Degree53:master into 91f8823 on heldinz:master.

@heldinz heldinz merged commit 012d8da into heldinz:master May 24, 2016
@heldinz
Copy link
Owner

heldinz commented May 24, 2016

Great, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickihastings @heldinz @coveralls