Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gulp-util to plugin-error and some upgrade #5

Merged
merged 5 commits into from
Sep 23, 2018

Conversation

Bargamut
Copy link
Contributor

Hi there!

gulp-util is deprecated and replaced to plugin-error package.

See more on this page:
https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

BTW: This request have some upgrades of devDependencies

new Buffer() // this is deprecated

Buffer.from() // some of actual variants

After replace gulp-util in test.js were some errors with code like this:

// new variant of
// stream.write(new gutil.File({
stream.write(new Vinyl({
	// some your options
	contents: es.readArray([new Buffer([0xe4, 0xf6, 0xfc, 0xdf])])
}));

and find solution (?):

var mystream = require('stream');

stream.write(new Vinyl({
	// some your options
	new mystream.Readable({objectMode: true}).wrap(es.readArray([Buffer.from([0xe4, 0xf6, 0xfc, 0xdf])]))
}));

In case of pain in your eyes - sorry about that - I just tried to help. ))

@coveralls
Copy link

coveralls commented Aug 18, 2018

Coverage Status

Coverage increased (+0.02%) to 97.917% when pulling 07b3ea2 on Bargamut:master into 90ae4cb on heldinz:master.

@irudoy
Copy link

irudoy commented Sep 14, 2018

@heldinz when you plan to merge it?

@heldinz
Copy link
Owner

heldinz commented Sep 17, 2018

Hey @Bargamut thanks so much for this! I missed the notification somehow, so apologies for not seeing this sooner. Looks great at first glance, I will take a proper look ASAP.

Copy link
Owner

@heldinz heldinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@heldinz heldinz merged commit 05300e6 into heldinz:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants