Crashing helix in mouse mode leaves terminal in bad state

[Zoybean]

Summary

While mouse was enabled, crashed helix.
In the terminal afterward, moving the mouse caused a spam of keycodes to the terminal

Reproduction Steps

I tried this:

1. Set mouse mode in config.toml
2. Start helix
3. Crash helix eg using kill

I expected this to happen:

• Terminal is left in the same state as before running helix

Instead, this happened:

• Terminal is left in a state where it responds to mouse movements by typing junk

Helix log

No response

Platform

Linux (Ubuntu on WSL)

Terminal Emulator

Windows Terminal Version: 1.12.10982.0

Helix Version

22.03-121-g6de2e763

[eduardorittner]

Shouldn't this issue be closed due to #7236?

[the-mikedavis]

Yeah we can say this was mostly fixed by #7236 - we now intercept kill signals and close gracefully. For the other part of this (crashes) I'm not sure we can do much better - we have a panic handler that tries to restore the terminal but it doesn't have access to program state so it can only really guess how to restore.