Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit gracefully on termination signals #7236

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

the-mikedavis
Copy link
Member

On SIGINT or SIGTERM, restore the terminal and exit gracefully. This mirrors the behavior of Vi and Kakoune on these signals and should be a nicer behavior when killing a Helix process.

Closes #6754
Closes #6962

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Jun 5, 2023
On SIGINT or SIGTERM, restore the terminal and exit gracefully. This
mirrors the behavior of Vi and Kakoune on these signals and should be a
nicer behavior when `kill`ing a Helix process.
@the-mikedavis the-mikedavis force-pushed the handle-termination-signals branch from b91536a to b6b2a2d Compare June 5, 2023 13:09
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@archseer archseer merged commit 428d33a into master Jun 5, 2023
@archseer archseer deleted the handle-termination-signals branch June 5, 2023 13:27
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helix leaves terminal in a bad state when killed
4 participants